Added laminas-diactoros
#276
Conversation
|
TBH: I dont know what to change to make this PR working. I am not that familiar in all that documentation tools around. Can someone guide me a bit to get this fixed? |
There was a problem hiding this comment.
thanks a lot for php-http/discovery#169 and this!
i think most of the errors are not about changes you do here, and we need to fix them elsewhere. however, one is about "Laminas" not being a known word. please add that in https://github.com/php-http/documentation/blob/master/spelling_word_list.txt (in alphabetic position)
|
i fixed the other spelling erros in #277, if you rebase and add |
- Moved zend-diactoros to the end of lists - Changed installation example to `laminas-diactoros` - Marked zend-diactoros as abandoned where possible
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
force-pushed
the
laminas-diactoros
branch
from
67881e1 to
c89c3c6
Compare
|
Hm, I've rebased and added |
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
|
thanks a lot! |
What's in this PR?
laminas-diactorosWhy?
As of the end of 2019, zendframework got abandoned and laminas was released.
Thus, laminas-diactoros replaced diactoros of zendframework.
I am not sure how you guys want to handle that replace. I've created a PR in php-http/discovery#169 in order to add support for laminas.
Should we drop the zendframework part totally from the documentation or keep it as the package still supports zendframework?
Would love to get some feedback here.